forked from Mirrors/Paymenter
Add user key field #1
Kodomu
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/add-user-key"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some small suggestions.
@ -40,0 +36,4 @@$user = User::create(['first_name' => $this->option('first_name') ?? '','last_name' => $this->option('last_name') ?? '','email' => $this->option('email') ?? '',Should these fields be empty instead of null
Shouldn't matter
@ -39,1 +37,3 @@'email' => 'required|email|max:255|unique:users','first_name' => 'string|max:255','last_name' => 'string|max:255','email' => 'email|max:255',Again here, should we use nullable instead of just removing required?
@ -0,0 +4,4 @@<x-logo class="h-10" /><h1 class="text-2xl text-center mt-6">{{ __('auth.sign_up_complete.title') }}</h1><div class="text-base text-center mt-6">{{ __('auth.sign_up_complete.user_key_info') }}</div><div class="text-lg font-semibold text-center mt-6">{{ $user_key }}</div>Let's use this here to make it easier to copy and present it better.
What happens if email notifications go to a user that doesn't have an email assigned?
This is most likely ready now